From 3a2958c7061b028de2b32d8d33deaa258e082a0d Mon Sep 17 00:00:00 2001
From: blyssco <youssefboulaich@outlook.com>
Date: Thu, 24 Jul 2025 20:03:19 +0200
Subject: [PATCH] Fix after pr review

---
 Domain/DTO/UpdateSpell.cs               | 18 ++++++++++++++++++
 Domain/Entities/Magician.cs             | 16 ++++++++++++++++
 Domain/Entities/Spell.cs                | 12 +++---------
 Domain/Filters/SpellFilter.cs           |  8 +-------
 Domain/Repositories/ISpellRepository.cs | 12 ++++--------
 5 files changed, 42 insertions(+), 24 deletions(-)
 create mode 100644 Domain/DTO/UpdateSpell.cs
 create mode 100644 Domain/Entities/Magician.cs

diff --git a/Domain/DTO/UpdateSpell.cs b/Domain/DTO/UpdateSpell.cs
new file mode 100644
index 0000000..6e00350
--- /dev/null
+++ b/Domain/DTO/UpdateSpell.cs
@@ -0,0 +1,18 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Domain.DTO
+{
+    public class UpdateSpell
+    {
+        public required Guid id {  get; set; }
+        public string? Name {  get; set; }
+        public string? Description { get; set; }
+        public string? Type { get; set; }
+        public string? Creator { get; set; }
+        public DateTime? CreationDate { get; set; }
+    }
+}
diff --git a/Domain/Entities/Magician.cs b/Domain/Entities/Magician.cs
new file mode 100644
index 0000000..145594e
--- /dev/null
+++ b/Domain/Entities/Magician.cs
@@ -0,0 +1,16 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Domain.Entities
+{
+    public class Magician
+    {
+        public Guid Id { get; private set; }
+        public required string Name { get; set; }
+        public required string Speciality { get; set; }
+
+    }
+}
diff --git a/Domain/Entities/Spell.cs b/Domain/Entities/Spell.cs
index 0d1c830..61d7467 100644
--- a/Domain/Entities/Spell.cs
+++ b/Domain/Entities/Spell.cs
@@ -1,18 +1,12 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace Domain.Entities
+namespace Domain.Entities
 {
     public class Spell
     {
-        public Guid Id { get; set; }
+        public Guid Id { get; private set; }
         public required string Name { get; set; }
         public required string Type { get; set; }
         public required string Description { get; set; }
-        public required string Creator { get; set; }
         public required DateTime CreationDate { get; set; }
+        public required Magician Magician { get; set; }
     }
 }
diff --git a/Domain/Filters/SpellFilter.cs b/Domain/Filters/SpellFilter.cs
index d17fb0c..356b5fd 100644
--- a/Domain/Filters/SpellFilter.cs
+++ b/Domain/Filters/SpellFilter.cs
@@ -1,10 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace Domain.Filters
+namespace Domain.Filters
 {
     public class SpellFilter
     {
diff --git a/Domain/Repositories/ISpellRepository.cs b/Domain/Repositories/ISpellRepository.cs
index 6629d96..a9b929f 100644
--- a/Domain/Repositories/ISpellRepository.cs
+++ b/Domain/Repositories/ISpellRepository.cs
@@ -1,10 +1,6 @@
-using Domain.Entities;
+using Domain.DTO;
+using Domain.Entities;
 using Domain.Filters;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Domain.Repositories
 {
@@ -13,8 +9,8 @@ namespace Domain.Repositories
         Task<ICollection<Spell>> GetAll();
         Task<Spell> GetSpellById(Guid id);
         Task<ICollection<Spell>> GetFilteredSpells(SpellFilter spellfilter);
-        Task<Spell> UpdateSpell(Spell spell);
-        Task<string> DeleteSpell(Spell spell);
+        Task<Spell> UpdateSpell(UpdateSpell updateSpellObject);
+        Task<bool> DeleteSpell(Guid id);
         Task<Spell> CreateSpell(Spell spell);
     }
 }